Code cleanup after #649: removed unnecessary bounds + string, and removed clojure-dot rule#650
Open
RuijieYu wants to merge 3 commits intoabo-abo:masterfrom
Open
Code cleanup after #649: removed unnecessary bounds + string, and removed clojure-dot rule#650RuijieYu wants to merge 3 commits intoabo-abo:masterfrom
RuijieYu wants to merge 3 commits intoabo-abo:masterfrom
Conversation
RuijieYu
changed the title
Fixes bug#653. * lispy-test.el (lispy-simulate-key) (lispy-simulate-keys) (lispy-simulate-expect): Added facilities to assert results after a given set of keypresses. (lispy-read-unsafe-chars): added regression tests for bug#648.
Fixes bug#648. * lispy.el lispy--symbol-safe-chars: define list of safe chars. (lispy--read): protect against unsafe chars in a symbol. (lispy--replace-regexp-in-code): add predicate to only replace on match data.
lispy.el (lispy--read) (lispy--insert): removed unreachable clojure dot rule, because it is always covered by the unsafe character rule.
RuijieYu
force-pushed
the
cleanup-bug-648-clisp-dot-in-symbol
branch
from
6ce8d1a to
949e6d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #649.
The first two commits are #649 itself, and the only commit of interest is 949e6d1.
The PR's goal is to remove clojure-dot rule entirely. This is because the clojure-dot rule is always covered by unsafe symbol, which can be tested by letting lispy parse
(. hello world).